Hello,

I just set up a site with com_multisites and the multisites_ssidomains-Plugin.

On our hosting server, PHP-Notices are shown and com_multisites and the plugin produce a couple:

The Plugin shows a PHP-Notice in the Plugin configuration page regarding $addMaster:
To fix:
File: /administrator/components/com_multisites/elements/domains.php, line 146:

The Plugin didn't seem to work with the 'automatic' setting, so I dug in and could get it working:
File: /plugins/system/multisites_ssidomains/multisites_ssidomains.php
Line 66:


Line 365:

Now the SSI-Plugin works with setting 'automatic'. com_multisites still brings an error on the 'Check for Updates'-Page, but I won't try to fix it for now:

Notice: Undefined property: JAdministrator::$JComponentTitle in /home/httpd/vhosts/DOMAIN/httpdocs/administrator/modules/mod_title/mod_title.php on line 13

Can you add the fixes to future release?

Kind regards

-Stephan

Edit: Our versions:
PHP 5.3.17
Version 1.2.97 (Latest available: 1.2.97)
Patches definition Version 1.2.91 (Latest available: 1.2.91)

Concerning the PHP Notice and the test that you added to verify that the variable is present, I will add the test in a next release.

Concerning the change in the line 66 to replace the assign of the result with an indice instead of a key, this is not ok. You can not do that. The key is required in other processing.

I think that you should add a line in 241 to ensure that the results is always using an indice and not a key.
$cookie_domains = array_values( $cookie_domains);

// BEFORE
if ( method_exists( $this, $fn)) {
$cookie_domains = $this->$fn();
}
// AFTER
if ( method_exists( $this, $fn)) {
$cookie_domains = $this->$fn();
$cookie_domains = array_values( $cookie_domains);
}

Thanks for the fast reply! I applied your changes.

kind regards

-Stephan