English (United Kingdom)
Jms Multi Site, formerly joomla multisite.
Create, share multiple joomla sites in few clicks !
Message
  • EU e-Privacy Directive

    This website uses cookies to manage authentication, navigation, and other functions. By using our website, you agree that we can place these types of cookies on your device.

    View e-Privacy Directive Documents

Welcome, Guest
Please Login or Register.    Lost Password?
Go to bottomPage: 1
TOPIC: SSI-Plugin: PHP Notices
#10972
SSI-Plugin: PHP Notices 11 Years, 3 Months ago Karma: 0
Hello,

I just set up a site with com_multisites and the multisites_ssidomains-Plugin.

On our hosting server, PHP-Notices are shown and com_multisites and the plugin produce a couple:

The Plugin shows a PHP-Notice in the Plugin configuration page regarding $addMaster:
To fix:
File: /administrator/components/com_multisites/elements/domains.php, line 146:
Code:

old: if ( $addMaster) {
new: if ( isset($addMaster) && $addMaster) {


The Plugin didn't seem to work with the 'automatic' setting, so I dug in and could get it working:
File: /plugins/system/multisites_ssidomains/multisites_ssidomains.php
Line 66:
Code:

old: $results[$domain] = $domain;
new: $results[] = $domain;



Line 365:
Code:

old: if( $processed_domains[$domain] || $processed_domains['www.'.$domain]){
new: if( isset($processed_domains[$domain]) || isset($processed_domains['www.'.$domain])){


Now the SSI-Plugin works with setting 'automatic'. com_multisites still brings an error on the 'Check for Updates'-Page, but I won't try to fix it for now:

Notice: Undefined property: JAdministrator::$JComponentTitle in /home/httpd/vhosts/DOMAIN/httpdocs/administrator/modules/mod_title/mod_title.php on line 13

Can you add the fixes to future release?

Kind regards

-Stephan

Edit: Our versions:
PHP 5.3.17
Version 1.2.97 (Latest available: 1.2.97)
Patches definition Version 1.2.91 (Latest available: 1.2.91)
iage
Junior Boarder
Posts: 23
graphgraph
User Offline Click here to see the profile of this user
Last Edit: 2012/12/05 10:54 By iage.
The administrator has disabled public write access.
 
#10989
Re: SSI-Plugin: PHP Notices 11 Years, 3 Months ago Karma: 54
Concerning the PHP Notice and the test that you added to verify that the variable is present, I will add the test in a next release.

Concerning the change in the line 66 to replace the assign of the result with an indice instead of a key, this is not ok. You can not do that. The key is required in other processing.

I think that you should add a line in 241 to ensure that the results is always using an indice and not a key.
$cookie_domains = array_values( $cookie_domains);

// BEFORE
if ( method_exists( $this, $fn)) {
$cookie_domains = $this->$fn();
}
// AFTER
if ( method_exists( $this, $fn)) {
$cookie_domains = $this->$fn();
$cookie_domains = array_values( $cookie_domains);
}
edwin2win
Moderator
Posts: 5370
graph
User Offline Click here to see the profile of this user
The administrator has disabled public write access.
 
#10992
Re: SSI-Plugin: PHP Notices 11 Years, 3 Months ago Karma: 0
Thanks for the fast reply! I applied your changes.

kind regards

-Stephan
iage
Junior Boarder
Posts: 23
graphgraph
User Offline Click here to see the profile of this user
The administrator has disabled public write access.
 
Go to topPage: 1
get the latest posts directly to your desktop
2Win, Multisite(s) are trademarks of Edwin2Win.
Joomla